RE: [PATCH] xfrm_policy delete security check misplaced

From: Venkat Yekkirala
Date: Mon Mar 05 2007 - 12:10:55 EST


> > >
> > > Signed-off-by: Eric Paris <eparis@xxxxxxxxxx>
> > Acked-by: Venkat Yekkirala <vyekkirala@xxxxxxxxxxxxx>
>
> What about your previous comment:
>
> "I guess you meant to do this here?
> else if (err)
> return err; "

I saw that this was taken care of in patch-2 for the delete case, but
while err isn't currently applicable to the non-delete case, it would
be proper/complete for err to still be handled for the non-delete case.
Thanks for asking.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/