Re: [PATCH] slim: move file revocation into file_table.c and mprotect.c

From: Mimi Zohar
Date: Fri Feb 23 2007 - 13:13:29 EST


serue@xxxxxxxxxxxxxxxxxx wrote on 02/20/2007 11:58:24 AM:

> Here is a attempt at resolving some of the complaints against the
> slim security module. The file revocation is perceived as too
> intrusive to live in a security module itself, so it is moved into
> file_table.c.
>
> This patch retains the explicit file->f_mode tweaking to revoke
> FMODE_WRITE. That can be removed by using an approach like Pekka's
> revokefs, using files in the revokefs filesystem with ->read() passed
> through to the original file, but ->write() intercepted.
>
> Comments greatly appreciated.

I've tested the patch with slim. The patch has been up and running
on my system for a couple of weeks now, and it seems to be working
just fine. Is the approach acceptable? On the assumption that it
is, how should we go forward with it? Can it get a test run in -mm?
If not, what would be a more acceptable approach?

Thanks!

Mimi Zohar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/