Re: [PATCH] free swap space when (re)activating page

From: Bodo Eggert
Date: Thu Feb 22 2007 - 20:43:06 EST

Rik van Riel <riel@xxxxxxxxxx> wrote:

+++ linux-2.6.20.noarch/mm/swap.c        2007-02-20 06:44:17.000000000 -0500
@@ -420,6 +420,26 @@ void pagevec_strip(struct pagevec *pvec)

> +                        if (printk_ratelimit())
> +                                printk("kswapd freed a swap space\n");


1) This message is a debug message! You forgot to set the printk level.

2) The message text is bad, the average log reader only knows swap files
and pages in swapfiles. The first reaction will be like "WTF happened
to my swap???". Thousands of admins will cry out in anguish trying to
get the meaning of this message, and again cry out in wrath after they
found out.

3) What should I do if I see this message? It's neither good, nor bad for
me, nor is it in any way informative even if it were changed to be
meaningfull. It's utterly useless! Let it be!

We are all born ignorant, but one must work hard to remain stupid.
-- Benjamin Franklin

Friß, Spammer: JEN-ersdiT@xxxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at