Re: [PATCH 4/4] NOMMU: Make it possible for RomFS to use MTD devices directly

From: David Howells
Date: Thu Feb 22 2007 - 06:44:33 EST

Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> > + brelse(bh);
> A little fyi: brelse() is rather old-fashioned, and has a usually unneeded
> test for non-null bh in it. In situations where we know that the pointer is
> valid, let's please use put_bh().

That's what was in the old romfs. I can make the change, though.

Hmmm... brelse() isn't quite equivalent to put_bh(), but the difference seems
just to be the message you get if you over-release a buffer head - and the
resulting refcount on the BH if that happens.

> Anyway, I'll assume that dwmw2 will be handling this patch series.

I assume so.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at