Re: [kvm-devel] [PATCH 10/13] KVM: Wire up hypercall handlers toa central arch-independent location

[Avi Kivity]

Joerg Roedel wrote:
> On Thu, Feb 22, 2007 at 02:17:54AM -0800, Dor Laor wrote:
>   
> > I have Ingo's network PV hypercalls to commit in my piplien.
> > Till then we can just add the test hypercall:
> > 	case __NR_hypercall_test:
> > 		printk(KERN_DEBUG "%s __NR_hypercall_test\n",
> > __FUNCTION__);
> > 		ret = 0x5a5a;
> > 		break;
> > 	default:
> > 		BUG();
> >     
>
> Is it a good idea to call BUG() on an undefined hypercall? I assume its
> better to inform the guest that is has issued an illegal call...
>
>   

The code returns -KVM_EINVAL if the hypercall is not handled (and BUG() 
on the host as a response to something controlled by a guest is not a 
good idea).


--
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/