Re: ACPI: ibm-acpi: fix initial status of backlight device

From: Richard Purdie
Date: Thu Feb 22 2007 - 05:03:40 EST


On Wed, 2007-02-21 at 23:16 -0200, Henrique de Moraes Holschuh wrote:
> NOTE: This patch needs an ACK from Richard Purdie before it can be merged,
> as he might want to change the backlight class code instead.

As mentioned elsewhere, we can't do this in the class itself.

> --- a/drivers/acpi/ibm_acpi.c
> +++ b/drivers/acpi/ibm_acpi.c
> @@ -1713,6 +1713,13 @@ static struct backlight_properties ibm_backlight_data = {
>
> static int brightness_init(void)
> {
> + int b;
> +
> + b = brightness_get(NULL);
> + if (b < 0)
> + return b;
> + ibm_backlight_data.brightness = b;
> +
> ibm_backlight_device = backlight_device_register("ibm", NULL, NULL,
> &ibm_backlight_data);

This isn't against 2.6.21-rc1 which changed the backlight class a bit.
Basically, you need to set the brightness variable after
backlight_device_register(). It should be simple enough to do and fix
the problem the same way though.

Richard


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/