Re: [uml-devel] [PATCH 2/3] UML - x86_64 thread fixes

From: Blaisorblade
Date: Wed Feb 21 2007 - 19:07:54 EST


On Thursday 08 February 2007 22:57, Jeff Dike wrote:
> x86_64 needs some TLS fixes. What was missing was remembering the
> child thread id during clone and stuffing it into the child during
> each context switch.
>
> The %fs value is stored separately in the thread structure since the
> host controls what effect it has on the actual register file. The
> host also needs to store it in its own thread struct, so we need the
> value kept outside the register file.
Is there any reason for avoiding this treatment to %gs, apart that TLS code
usually does not need it, even if the API allows for it to exist? I _do_
believe this patch fixes bug which can be tested (not verified everything),
even if I wonder why you didn't look at the patch I sent to you time ago (I
hadn't finished it, in truth, but there was most stuff - it had problems I
couldn't debug at that time).
--
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale!
http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/