Re: [Xen-devel] Re: [patch 17/24] Xen-paravirt_ops: avoid havinga bad selector in %gs during context switch
From: Jeremy Fitzhardinge
Date: Wed Feb 21 2007 - 18:30:16 EST
Zachary Amsden wrote:
> I agree with that, but especially because this is not even the right
> place to save and clear gs; when userspace uses an LDT based %gs, you
> need to do this all the way back in mmu_context.h before you switch
> the LDT out.
Yeah. This patch was really just to shut my debug Xen build up.
There's no correctness issue one way or the other, so it doesn't really
matter that it doesn't catch LDT-using processes.
> And I noticed this martian hanging out in mmu_context.h:
> #define deactivate_mm(tsk, mm) \
> asm("movl %0,%%gs": :"r" (0));
Yeah, I've always wondered what this is for. Its a remnant of a
remnant, I think.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/