Re: [PATCH 1/3] slab: introduce krealloc

From: Pekka Enberg
Date: Wed Feb 21 2007 - 14:20:06 EST


On 2/21/07, Christoph Lameter <clameter@xxxxxxx> wrote:
Why not? Its a realloc call and these are the classic semantics of
realloc. Otherwise realloc will always move the memory.

Well, as a reference, the user-space equivalent is defined in SUSv3 as:

"The realloc() function shall change the size of the memory object
pointed to by ptr to the size specified by size."

I think it is reasonable to expect krealloc() to not waste too much
space if I, say, reallocate a 128 byte buffer to 32 bytes.

On 2/21/07, Christoph Lameter <clameter@xxxxxxx> wrote:
Check that both sizes fall into the same general cache. Do the following
at the beginning of the function

Not available in the slob allocator AFAIK but yeah, I'll add this
optimization to the slab version. Thanks Christoph.

Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/