Re: securityfs_create_dir strange comment

From: Serge E. Hallyn
Date: Tue Feb 20 2007 - 16:19:20 EST

Quoting Jan Engelhardt (jengelh@xxxxxxxxxxxxxxx):
> Hello list,
> in security/inode.c, the comment for securityfs_create_dir() reads:
> If securityfs is not enabled in the kernel, the value -ENODEV
> will be returned. It is not wise to check for this value, but
> rather, check for NULL or !NULL instead as to eliminate the need
> for #ifdef in the calling code.
> What is the actual callee that can return NULL - and what should
> module_init() of a module return when securityfs_create_dir() returns

Hmm, this came from GregKH. It does seem based on the code that
checking for -ENODEV is necessary, so I don't understand the comment.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at