Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic additionand removal of adapters

From: John Rose
Date: Tue Feb 20 2007 - 12:28:34 EST


> If the probe operation succeeds, the respective device will show up
> beneath
> /sys/bus/ibmebus/devices.

This approach is not particularly synchronous. Take the case of an add
failure: how long would an application wait before deciding that the new
device is not going to appear?

It might be preferable to have the write to the probe function fail.
For example, if we can't find the device node, return -EINVAL or
something.

> This is already taken care of by of_device_register().

If we are scrapping the use of of_device for ibmebus devices, can we
still create a devspec file for OF correlation purposes?

Thanks-
John

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/