Re: Kbuild problem

From: Joerg Dorchain
Date: Tue Feb 20 2007 - 09:38:29 EST


On Tue, Feb 20, 2007 at 02:56:27PM +0100, Tilman Schmidt wrote:
> > One disadvantage of this approach is that in a kernel with
> > CONFIG_GIGASET_BASE=y, you can't later compile and load the usb_gigaset
> > or ser_gigaset modules without rebooting since they require a change to
> > the kernel image.
>
> You've got a point there. So linking asyncdata.o into the modules that
> need it, as it is currently done, would perhaps be better after all?

From the architectural point of view, what odds against making it a
module of its own? Dependancies are resolved by modprobe, so users should
be fine.
There are other library-like parts in the kernel where an object is
built statically when at least one needing driver is static, a module
when all nedding drivers are modules, or not at all but appears are a
config option when no in-kernel driver needs it.

>
> The alternative would be to always link asyncdata.o into the gigaset
> module whether it's needed or not. "size asyncdata.o" says:
> text data bss dec hex filename
> 4200 0 0 4200 1068 asyncdata.o
> which appears tolerable.

Ugly. But I've seen worse.

Bye,

Joerg

Attachment: signature.asc
Description: Digital signature