Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event

From: Zach Brown
Date: Mon Feb 19 2007 - 19:27:35 EST


I would argue that one common cause of the EIO is userland
error (mmap concurrent with O_DIRECT), and EIO is the correct answer.

I disagree. That means that using the pagecache to synchronize things like
the proposed online defragmentation will occasionally make O_DIRECT users
fail.

Well, only if the pages couldn't be invalidated. Arguably ext3 should be trying a lot harder to invalidate before giving up and returning failure from invalidate_page().

Hopefully this all goes away in the long term with Chris' "placeholder" work that stops insertions into the radix tree while dio ops are in flight.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/