<linux/socket.h>, <linux/stat.h> breakage: AF_* constants are partof ABI definition
From: H. Peter Anvin
Date: Mon Feb 19 2007 - 16:06:54 EST
In the current git tree, commit 57a87bb0720a5cf7a9ece49a8c8ed288398fd1bb
removes any way to automatically extracting a whole lot of ABI constants
from the kernel headers, especially AF_* and the various S_* constants.
Furthermore, the patch breaks <linux/in.h> which uses sa_family_t, which
is now defined under __KERNEL__.
The comment that is included:
[PATCH] scrub non-__GLIBC__ checks in linux/socket.h and
Userspace should be worrying about userspace, so having the socket.h
and stat.h pollute the namespace in the non-glibc case is wrong and
pretty much prevents any other libc from utilizing these headers
sanely unless they set up the __GLIBC__ define themselves (which
... seems to imply that virtually nothing out of these files should be
"sanely" utilized, but why, pray tell, include them at all? The balance
of these files is about 10 lines.
This patch breaks klibc in ways that are painfully hard to fix, and
*definitely* cannot be fixed by anything less than replication of all
these definitions, which is exactly the Wrong Thing[TM].
A much better solution (or complement) would be something like:
#if defined(__KERNEL__) || defined(__KHDR_CONSTANTS)
We could have __KHDR_CONSTANTS for the AF_* constants and __KHDR_MACROS
for the various macros (cmsg et al). That way the userspace library can
ask for what it wants.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/