Re: [PATCH] input/spi: add ads7843 support to ads7846 touchscreen driver

From: David Brownell
Date: Mon Feb 19 2007 - 13:59:51 EST

On Monday 19 February 2007 4:48 am, Nicolas Ferre wrote:
> >> - /* maybe off internal vREF */
> >> - if (use_internal) {
> >
> > This part doesn't make sense. Could you say what you're trying
> > to do? The ads7846 requres an external vREF. Is the issue that
> > maybe the REF_OFF command isn't just turning off the (non-existent)
> > internal voltage reference? If so the comments need updating, and
> > maybe the name REF_OFF needs to change too...
> Well, on the ads7843, this command allow to put converter in low power
> mode and, more important, enable the PENIRQ (otherwise disabled).
> The REF_OFF command can be replaced by the PWRDOWN one (exactly the
> same command). This last name matches better the ads7843
> datasheet description (and seems ok considering the ads7846 one).

OK, that would be a better change then, along with comment update.

- Dave

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at