Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
From: Oleg Nesterov
Date: Mon Feb 19 2007 - 07:00:29 EST
On 02/19, David Howells wrote:
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> > Afaics, noautorel work_struct buys nothing for "struct net_bridge_port".
> You may be right.
> > If del_nbp()->cancel_delayed_work(&p->carrier_check) fails, port_carrier_check
> > may be called later anyway.
> Called by what? Something outside of br_if.c?
No. if cancel_delayed_work() fails, the work may sit pending in cwq->worklist,
or it may be running right now, waiting for rtnl_mutex.
> > So the reading of *work in port_carrier_check() is equally unsafe with or
> > without this patch.
> Hmmm... cancel_delayed_work() in del_nbp() probably ought to be followed by a
Yes, but this deadlocks: we hold rtnl_mutex, and work->func() takes it too.
I think the fix should be so that port_carrier_check() does get/put on
"struct net_bridge_port" (container), but not on "struct net_device", and
del_nbp(struct net_bridge_port *p)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/