Re: [RFC][PATCH][3/4] Add reclaim support

From: Balbir Singh
Date: Mon Feb 19 2007 - 05:53:51 EST


KAMEZAWA Hiroyuki wrote:
On Mon, 19 Feb 2007 12:20:42 +0530
Balbir Singh <balbir@xxxxxxxxxx> wrote:

+int memctlr_mm_overlimit(struct mm_struct *mm, void *sc_cont)
+{
+ struct container *cont;
+ struct memctlr *mem;
+ long usage, limit;
+ int ret = 1;
+
+ if (!sc_cont)
+ goto out;
+
+ read_lock(&mm->container_lock);
+ cont = mm->container;

+out:
+ read_unlock(&mm->container_lock);
+ return ret;
+}
+

should be
==
out_and_unlock:
read_unlock(&mm->container_lock);
out_:
return ret;



Thanks, that's a much convention!


-Kame



--
Warm Regards,
Balbir Singh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/