Re: [PATCH 00/44 take 2] [UBI] Unsorted Block Images
From: Christoph Hellwig
Date: Mon Feb 19 2007 - 05:50:43 EST
On Sat, Feb 17, 2007 at 06:54:24PM +0200, Artem Bityutskiy wrote:
> The structure of the UBI code is very simple. Whole UBI consists of units.
> Each unit has one .c file which implements it and one .h file which defines
> the interface of this unit. So I've split the UBI code so that there is
> a distinct patch for each unit header and implementations. Plus there are
> several patches like JFFS2 support, user-space-visible headers, etc.
> To realize what is the unit responsible for, glance at its header - there
> is a short description.
I think this is the wrong approach. For one thing the unit terms is
rather foregin in Linux, and second this one header file "unit" is
definitly too much. Normally you'd have as little as possible and at
(1) internal definitions of the driver
(2) external kernel interface of the driver if nessecary
(3) user interface of the driver if nessecary
(4) ondisk structure if nessecary
Also please make sure you submit patches at this driver level. You really
want one git commit per driver that is totally self-contained. If nessecary
you'd split this into multiple patches if a single one would be bigger then
the message size limit.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/