Re: [PATCH 2.6.21-rc1] ibmebus: Use of_device_uevent()

From: Joachim Fenkes
Date: Sat Feb 17 2007 - 10:53:36 EST


Sylvain Munaut <tnt@xxxxxxxxxx> wrote on 17.02.2007 04:36:01:

> Doesn't that oops when called with the fake parent device ?

I should stop posting patches after 12 hours of work ,)

> Or, an even better approach is to add this
>
> + if (!ebus_dev->ofdev.node)
> + return -ENODEV;
>
> inside the code of of_device_uevent itself.

Nice! Patch will follow.

Thanks again,
Joachim

---
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
extraordinaire
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Development
2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
eMail: fenkes@xxxxxxxxxx -- Phone: +49 7031 16 1239

Vorsitzender des Aufsichtsrats: Johann Weihen -- Geschäftsführung:
Herbert Kircher
Sitz der Gesellschaft: Böblingen -- Registergericht: Amtsgericht
Stuttgart, HRB 243294


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/