Re: [Cbe-oss-dev] [RFC, PATCH] CELL Oprofile SPU profiling updated patch
From: Arnd Bergmann
Date: Fri Feb 16 2007 - 12:15:40 EST
On Friday 16 February 2007 01:32, Maynard Johnson wrote:
> config OPROFILE_CELL
> bool "OProfile for Cell Broadband Engine"
> depends on OPROFILE && SPU_FS
> default y if ((SPU_FS = y && OPROFILE = y) || (SPU_FS = m &&
> OPROFILE = m))
> Profiling of Cell BE SPUs requires special support enabled
> by this option. Both SPU_FS and OPROFILE options must be
> set 'y' or both be set 'm'.
> Can anyone see a problem with any of this . . . or perhaps a suggestion
> of a better way?
The text suggests it doesn't allow SPU_FS=y with OPROFILE=m, which I think
should be allowed. I also don't see any place in the code where you actually
Ideally, you should be able to have an oprofile_spu module that can be
loaded after spufs.ko and oprofile.ko. In that case you only need
depends on OPROFILE && SPU_FS
and it will automatically build oprofile_spu as a module if one of the two
is a module and won't build it if one of them is disabled.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/