Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

From: Sergei Shtylyov
Date: Fri Feb 16 2007 - 08:48:39 EST


Andrew Morton wrote:

+ status = *(volatile u32 *)up->port.private_data;

It distresses me that this patch uses a variable which this patch
doesn't initialise anywhere. It isn't complete.

I assume this gets passed via early_serial_setup(). Marc?

The sub-driver code whch sets up this field shuld be included in the
patch, no?

Hardly so, this code (not a subdriver) resides under arch/mips/ I think.

WBR, Sergei
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at