Re: [PATCH] shm: Fix the locking and cleanup error handling indo_shmat.

[Wu, Bryan]

On Thu, 2007-02-15 at 22:34 -0500, Eric W. Biederman wrote:
> > drivers/video/Kconfig:1606:warning: 'select' used by config symbol
> 'FB_PS3' 
> > refer to undefined symbol 'PS3_PS3AV' 
> > /mnt/md0/devel/linux-mm/ipc/shm.c: In function 'do_shmat': 
> > /mnt/md0/devel/linux-mm/ipc/shm.c:945: warning: passing argument 1
> of 'IS_ERR' 
> > makes pointer from integer without a cast 
> > /mnt/md0/devel/linux-mm/ipc/shm.c:946: warning: passing argument 1
> of 'PTR_ERR' 
> > makes pointer from integer without a cast 
> > /mnt/md0/devel/linux-mm/ipc/shm.c:931: warning: label 'out_nattch'
> defined but 
> > not used 
> > /mnt/md0/devel/linux-mm/ipc/shm.c:890: error: label 'out_put_path'
> used but not 
> > defined 
> > make[2]: *** [ipc/shm.o] Error 1 
> > make[1]: *** [ipc] Error 2 
> > make: *** [_all] Error 2
> 
> Definitely some weird  patch application problem.
> 
> All of the calls to IS_ERR and PTR_ERR should have been removed. 
> Michal since it didn't seem to blow up when Andrew applied it I'm 
> going to assume the problem is on your end for now.
> 
> Eric
> 

Hi Eric,

I am also troubling with the incorrect "nattch" value in do_shmat().
Actually, I found this bugs when I do some LTP testing on
blackfin-uClinux platform.
The "nattch" value returned from shmctl() system call is wrong. 

So I think your patch can solve this bug. But which version Linux kernel
is your patch applying for? 
I want to do some test on my blackfin-uClinux 2.6.20 platform.

Thanks
-Bryan    
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/