Re: [patch 4/4] ipmi: add new IPMI nmi watchdog handling

From: Corey Minyard
Date: Thu Feb 15 2007 - 19:26:25 EST


Andrew Morton wrote:
On Thu, 15 Feb 2007 09:49:15 -0600
Corey Minyard <minyard@xxxxxxx> wrote:

So I see the following options besides what's already there:

1) add asm/kdebug.h and DIE_NMI_POST to everything that might have an IPMI implementation.
2) use CONFIG_X86 to tell if NMI will work, since that's the only thing it will work on at the present.

I don't have any way to know how different systems have implemented that feature, so I can't actually implement it for the various architectures (plus I don't have any of those boards). So maybe #2 is the best?

I tend to think that #1 is the best option - it keeps things consistent
and it gives arch/board maintainers a framework in which to add the
support code at their leisure. But it's something which would be best
worked through with the affected arch maintainers, please.

Which architectures are we talking about here? ia64 and ppc?
I'm not 100% sure, to tell you there truth. I know there are ARM, PPC,
x86, SPARC, ia64, and MIPS systems that have IPMI. But you can stick
it on anything, really. I'd like to be able to have basic support work
without having to add arch-specific things for one feature of the driver.

-Corey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/