Re: [-mm patch] MARKERS should depend on, not select MODULES

[Mathieu Desnoyers]

* Adrian Bunk (bunk@xxxxxxxxx) wrote:
> On Thu, Feb 15, 2007 at 05:14:08AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.20-rc6-mm3:
> >...
> > +linux-kernel-markers-kconfig-menus.patch
> >...
> >  Linux Kenrel Markers
> >...
> 
> Never ever select MODULES.
> 
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
> 
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>

> ---
> 
> BTW: Can we get in-kernel users?
> 

It could apply to any subsystems that needs hooks. (selinux?)


> --- linux-2.6.20-mm1/kernel/Kconfig.marker.old	2007-02-15 15:54:10.000000000 +0100
> +++ linux-2.6.20-mm1/kernel/Kconfig.marker	2007-02-15 15:54:27.000000000 +0100
> @@ -2,8 +2,7 @@
>  
>  config MARKERS
>  	bool "Activate markers"
> -	select MODULES
> -	default n
> +	depends on MODULES
>  	help
>  	  Place an empty function call at each marker site. Can be
>  	  dynamically changed for a probe function.
> 

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Candidate, École Polytechnique de Montréal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/