Re: [PATCH, RFC] adjust legacy IDE resource setting

From: Alan
Date: Wed Feb 14 2007 - 10:56:22 EST


> The masking is done primarily to (a) calculate the correct length (from a BAR's
> perspective), as I don't want to write the BAR if its length doesn't match the
> expectation, and (b) to properly report the new value in the printk.

Ok I guess you have to do something like that since you can't properly
encode BAR 1 and BAR 3.

> Of course I also opened a bug against X, as I too think it's doing something
> wrong here.

If you can add a comment about why it is done (X problem) then it looks
fine to me.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/