Re: [patch] build error: allnoconfig fails on mincore/swapper_space
From: Nick Piggin
Date: Tue Feb 13 2007 - 20:34:02 EST
Hugh Dickins wrote:
On Tue, 13 Feb 2007, Randy Dunlap wrote:
From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
Don't check for pte swap entries when CONFIG_SWAP=n.
And save 'present' in the vec array.
mm/built-in.o: In function `sys_mincore':
(.text+0xe584): undefined reference to `swapper_space'
Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
What you've done there is fine, Randy, thank you.
Can't you have migration without swap?
But I just got out of bed to take another look, and indeed:
what is it doing in the none_mapped !vma->vm_file case?
passing back an uninitialized vector.
I must have completely forgotten about the vector :(
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/