Re: [RESEND][PATCH] 9p: add write-cache support to loose cache mode

From: Andrew Morton
Date: Tue Feb 13 2007 - 19:28:16 EST


> On Tue, 13 Feb 2007 17:55:31 -0600 Eric Van Hensbergen <ericvh@xxxxxxxxx> wrote:
> +static ssize_t
> +v9fs_file_write(struct file *filp, const char __user * data,
> + size_t count, loff_t * offset)
> +{
> + struct inode *inode = filp->f_path.dentry->d_inode;
> +
> + ssize_t ret;
> +
> + dprintk(DEBUG_VFS, "count %d offset %x\n",
> + (int)count, (int)*offset);
> + ret = v9fs_write(filp, data, NULL, count, offset);
> + invalidate_inode_pages2(inode->i_mapping);
> + return ret;
> +}
> +

invalidate_inode_pages2() can fail. It might be worth at least warning here
if it does.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/