Re: [patch 14/21] Xen-paravirt: Add XEN config options and disableunsupported config options.

From: Dan Hecht
Date: Tue Feb 13 2007 - 19:00:42 EST


On 02/13/2007 03:29 PM, Jeremy Fitzhardinge wrote:
Dan Hecht wrote:
I assume you plan to eventually get all this stuff working but just
want to prevent configurations that the Xen paravirt-ops isn't ready
for at the moment?

Instead can you do it this way:

config XEN
depends on PARAVIRT && !PREEMPT && HZ_100 && !DOUBLEFAULT && !KEXEC

That's a bit simpler code-wise, but it does make it pretty complex to
get everything just-so to even see the CONFIG_XEN option.


Not only is it simpler code-wise, but it is more to the point... it is CONFIG_XEN that needs to be fixed to handle PREEMPT, KEXEC, different HZ values, etc. Not the other way around.

Enabling the compile of any paravirt-ops backend shouldn't cripple the kernel in any way... instead, the burden should be on the xen paravirt-ops backend to be completed. CONFIG_PREEMPT shouldn't care about which paravirt-ops are compiled in. Instead, CONFIG_XEN is the one that needs !PREEMPT.

Dan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/