Re: [patch 02/11] syslets: add syslet.h include file, user API/ABI definitions

[Ingo Molnar]

* Indan Zupancic <indan@xxxxxx> wrote:

> > + * Execution control: conditions upon the return code
> > + * of the previous syslet atom. 'Stop' means syslet
> > + * execution is stopped and the atom is put into the
> > + * completion ring:
> > + */
> > +#define SYSLET_STOP_ON_NONZERO			0x00000008
> > +#define SYSLET_STOP_ON_ZERO			0x00000010
> > +#define SYSLET_STOP_ON_NEGATIVE			0x00000020
> > +#define SYSLET_STOP_ON_NON_POSITIVE		0x00000040
> 
> This is confusing. Why the return code of the previous syslet atom? 
> Wouldn't it be more clear if the flag was for the current tasklet? 
> Worse, what is the previous atom? [...]

the previously executed atom. (I have fixed up the comment in my tree to 
say that.)

> [...] Imagine some case with a loop:
> 
>   A
>   |
>   B<--.
>   |   |
>   C---'
> 
> What will be the previous atom of B here? It can be either A or C, but 
> their return values can be different and incompatible, so what flag 
> should B set?

previous here is the previously executed atom, which is always a 
specific atom. Think of atoms as 'instructions', and these condition 
flags as the 'CPU flags' like 'zero' 'carry' 'sign', etc. Syslets can be 
thought of as streams of simplified instructions.

> > +/*
> > + * Special modifier to 'stop' handling: instead of stopping the
> > + * execution of the syslet, the linearly next syslet is executed.
> > + * (Normal execution flows along atom->next, and execution stops
> > + *  if atom->next is NULL or a stop condition becomes true.)
> > + *
> > + * This is what allows true branches of execution within syslets.
> > + */
> > +#define SYSLET_SKIP_TO_NEXT_ON_STOP		0x00000080
> > +
> 
> Might rename this to SYSLET_SKIP_NEXT_ON_STOP too then.

but that's not what it does. It really 'skips to the next one on a stop 
event'. I.e. if you have three consecutive atoms (consecutive in linear 
memory):

	atom1 returns 0
	atom2 has SYSLET_STOP_ON_ZERO|SYSLET_SKIP_NEXT_ON_STOP set
	atom3

then after atom1 returns 0, the SYSLET_STOP_ON_ZERO condition is 
recognized as a 'stop' event - but due to the SYSLET_SKIP_NEXT_ON_STOP 
flag execution does not stop (i.e. we do not return to user-space or 
complete the syslet), but we continue execution at atom3.

this flag basically avoids having to add an atom->else pointer and keeps 
the data structure more compressed. Two-way branches are sufficiently 
rare, so i wanted to avoid the atom->else pointer.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/