Re: [PATCH x86 for review II] [34/39] i386: Use stack argumentsfor calling into EFI

From: Frédéric RISS
Date: Mon Feb 12 2007 - 14:45:49 EST


Le lundi 12 fÃvrier 2007 Ã 08:38 +0100, Andi Kleen a Ãcrit :
> When calling into the EFI firmware, the parameters need to be passed on
> the stack. The recent change to use -mregparm=3 breaks x86 EFI support.
> This patch is needed to allow the new Intel-based Macs to suspend to ram
> (efi.get_time is called during the suspend phase).
>
> Signed-off-by: Frederic Riss <frederic.riss@xxxxxxxxx>
> Signed-off-by: Andi Kleen <ak@xxxxxxx>

For 2.6.20, Linus merged a different version touching only
arch/kernel/efi.c. If you really prefer this version, I guess it should
be discussed more thoroughly with him and the EFI guys.

Fred.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/