Re: [GIT PATCH] SCSI updates for 2.6.20

From: Rolf Eike Beer
Date: Mon Feb 12 2007 - 10:21:09 EST


James Bottomley wrote:
> On Mon, 2007-02-12 at 11:29 +0100, Rolf Eike Beer wrote:
> > Am Sonntag, 11. Februar 2007 schrieb James Bottomley:
> > > This is the accumulated SCSI tree for 2.6.20. It is available at
> > >
> > > master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git
> >
> > You once again have not included this two patches Andrew sent you on
> > 20070602:
> >
> > [patch 08/33] remove extra newline from info message
>
> This one's waiting on Hannes to ack, since he's working in that driver

Ah, thanks. (Added Hannes to CC).

> > [patch 09/33] Fix scsi/scsi_transport.h compile error
>
> I did look at this one, but I can't find a configuration that will
> induce a compile error like the header says. It's pending further
> investigation.

Just try to compile a file that only includes this header. I don't know if
there is an existing (in-kernel) configuration where this can go wrong, I
found it when hacking a replacement for cpqfcTS. Nevertheless this is still a
bug, relying on a specific include order is just wrong.

Greetings,

Eike

Attachment: pgp00000.pgp
Description: PGP signature