Re: NAK new drivers without proper power management?

[Pavel Machek]

Hi!

> > "If the device requires that, implement .suspend and .resume or at least
>                                                                   ^^^^^^^^
> > define .suspend that will always return -ENOSYS (then people will know they
>   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > have to unload the driver before the suspend).  Similarly, if you aren't sure
> > whether or not the device requires .suspend and .resume, define .suspend that
>                                                            ^^^^^^^^^^^^^^^^^^^^
> > will always return -ENOSYS."
>   ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Can't the upper layer just assume -ENOSYS if .resume/.suspend is NULL?
> It's nicer if you don't have to implement dummy functions at all.

Unfortunately, drivers currently assume "NULL == nothing is needed",
so we'd have t do big search & replace... 
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/