Re: NAK new drivers without proper power management?

[Tilman Schmidt]

Hi,

Am 11.02.2007 23:37 schrieb Nigel Cunningham:
> On Sun, 2007-02-11 at 00:45 +0100, Tilman Schmidt wrote:
>> Am 10.02.2007 23:37 schrieb Nigel Cunningham:
>>> If your device requires power management, and you know it requires power
>>> management, why not just implement power management? [...]
>> Like it or not, power management is far from trivial, and people
>> writing device drivers have limited resources. [...]
> It's not that complex. All we're really talking about is a bit of extra
> code to cleanup and configure hardware state; things that the driver
> author already knows how to do. S3 might require a bit more
> initialisation if firmware needs to be reloaded or more extensive
> configuration needs to be done, but if there's firmware to be loaded,
> there is a reasonably good probability that we loaded it from Linux to
> start with anyway.

You are assuming a perfect world where driver authors have complete
knowledge of their devices. In reality, many drivers (including
those I have the mixed pleasure of maintaining) are based at least
in part on reverse engineering, and managing power states may well
fall into the domain of things not yet sufficiently reverse
engineered.

>> Also, in your argument you neglected a few cases:
>> - What if my device does not require power management?
> 
> Then you as a generic routine that does nothing but return success
> (potentially shared with other drivers that are in the same situation).

But if I just write an empty routine like that I open myself up to
criticism along the lines of "writing dummy routines just in order
to shut up kernel warnings". BTDT.

>> - What if I don't know whether my device requires power management?
> 
> The questions are straight forward: Is there hardware state that needs
> to be configured if you've just booted the computer and nothing else has
> touched it? If so, that needs to be done in a resume method. Do you need
> to clean up state prior to doing the things in the resume method, or
> otherwise do things to quiesce the driver? If so, they will need to be
> done in the suspend method. The result will be roughly similar to what
> you do for module load/unload, except maybe less complete in some cases.

I don't doubt your basic assessment. However it doesn't translate that
easily into a real implementation. In my case, I maintain a USB driver,
so I have to deal with USB specifics of suspend/resume which happen not
to be that well documented. My driver provides an isdn4linux device but
isdn4linux knows nothing about suspend/resume so I am on my own on how
to reconcile the two. The device itself, though in turn far from trivial,
is actually the least of my worries.

>> - What if I know my device would require power management, but don't
>>   know how to implement it?
> 
> I've just told you above :) Now you know!

No I don't. See above.

>>> -ENOSYS is just not acceptable.
>> Your argument falls down the moment you consider the alternative:
>> not merging the driver means that the device won't work at all.
>> (Given that out-of-tree drivers are actively discouraged, to put
>> it mildly.) That's arguably farther from "desktop readiness" than
>> a device not supporting power management.
> 
> I disagree (but I would, of course!). If we apply your logic
> consistently, we should merge the driver as soon as any code is written
> for it (anything is better than nothing). I'm simply arguing that a
> driver that handling suspend and resume should be as much of a
> requirement as not causing memory corruption or such like are.

Well, that's a common fallacy about applying any logic consistently.
There's a continuum of usefulness from "hardly works at all" through
"causes random memory corruption", "doesn't support power management",
and "does not support some esoteric protocol variety no one ever heard
of anyways" up to "supports any and all uses to which anyone could
possibly want to put the device". I would argue that "doesn't support
power management" is *much* farther up that ladder than, for example,
"causes random memory corruption".

Regards,
Tilman

-- 
Tilman Schmidt                          E-Mail: tilman@xxxxxxx
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)

Attachment: signature.asc
Description: OpenPGP digital signature