Re: [PATCH 2/2] Char: timers cleanup

[Wim Van Sebroeck]

Hi Jiri,

> timers cleanup
> 
> - Use timer macros to set function and data members and to modify
>   expiration time.
> - Use DEFINE_TIMER for global timers and do not init them at run-time in
>   these cases.
> - del_timer_sync is common in most cases -- we want to wait for timer
>   function if it's still running.

For the watchdog drivers: the timers are only used if the watchdog is active.
Why should we not init them at run time but use the DEFINE_TIMER macro?
Personnaly I prefer to use the same syntax in all the watchdog drivers
(thus either DEFINE_TIMER or either setup_timer() ).

Greetings,
Wim.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/