Re: Network: convert network devices to use struct device instead of class_device

From: Greg KH
Date: Thu Feb 08 2007 - 19:52:53 EST


On Thu, Feb 08, 2007 at 07:43:18AM -0500, Jeff Garzik wrote:
> Linux Kernel Mailing List wrote:
> >Gitweb:
> >http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=43cb76d91ee85f579a69d42bc8efc08bac560278
> >Commit: 43cb76d91ee85f579a69d42bc8efc08bac560278
> >Parent: 2943ecf2ed32632473c06f1975db47a7aa98c10f
> >Author: Greg Kroah-Hartman <gregkh@xxxxxxx>
> >AuthorDate: Tue Apr 9 12:14:34 2002 -0700
> >Committer: Greg Kroah-Hartman <gregkh@xxxxxxx>
> >CommitDate: Wed Feb 7 10:37:11 2007 -0800
> >
> > Network: convert network devices to use struct device instead of
> > class_device
> >
> > This lets the network core have the ability to handle suspend/resume
> > issues, if it wants to.
> >
> > Thanks to Frederik Deweerdt <frederik.deweerdt@xxxxxxxxx> for the arm
> > driver fixes.
> >
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> >---
> > drivers/infiniband/ulp/ipoib/ipoib_main.c | 33 ++--
> > drivers/infiniband/ulp/ipoib/ipoib_vlan.c | 11 +-
> > drivers/net/arm/at91_ether.c | 2 +-
> > drivers/net/arm/etherh.c | 2 +-
> > drivers/net/bonding/bond_sysfs.c | 287
> > +++++++++++++++++-----------
> > drivers/net/iseries_veth.c | 2 +-
> > drivers/net/macb.c | 36 ++--
> > drivers/net/smc911x.c | 2 +-
> > drivers/net/smc91x.c | 2 +-
> > drivers/net/wireless/hostap/hostap_main.c | 2 +-
> > drivers/net/wireless/orinoco.c | 4 +-
> > drivers/net/wireless/orinoco_cs.c | 2 +-
> > drivers/net/wireless/spectrum_cs.c | 2 +-
> > include/linux/netdevice.h | 5 +-
> > net/bridge/br_if.c | 2 +-
> > net/bridge/br_sysfs_br.c | 234 +++++++++++++-----------
> > net/bridge/br_sysfs_if.c | 2 +-
> > net/core/dev.c | 6 +-
> > net/core/net-sysfs.c | 175 ++++++++++--------
> > net/core/skbuff.c | 2 +-
> > 20 files changed, 451 insertions(+), 362 deletions(-)
>
> It's highly disappointing that this was never discussed on
> netdev@xxxxxxxxxxxxxxx, or even CC'd to me.

It was CCed to David Miller and you and netdev a long time ago (like 8-9
months ago.) It's been in the -mm tree since then and discussed on lkml
a few times too.

As I got David's ack for it, and he said to push it through my tree, I
didn't think any more of it.

My apologies, I should have consulted you again before doing it.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/