Re: [patch] export ufs_fs.h to userspace

From: Arjan van de Ven
Date: Thu Feb 08 2007 - 10:59:58 EST


On Thu, 2007-02-08 at 10:10 -0500, Mike Frysinger wrote:
> On Thursday 08 February 2007, Arjan van de Ven wrote:
> > On Thu, 2007-02-08 at 02:46 -0500, Mike Frysinger wrote:
> > > was ufs_fs.h purposefully not exported to userspace or did it just slip
> > > through the cracks ? assuming the latter scenario, the attached patch
> > > touches up the relationship between ufs_fs.h and its sub headers (like
> > > ufs_fs_sb.h) so that we can export it ... the silo bootloader takes
> > > advantage of this header for example
> >
> > are you sure it actually uses anything from this header, and not just
> > assumes the magic number to be there??
> > (also.. I kind of would think it reasonable for things with their own
> > UFS fs reader to have their own header)
>
> silo utilizes the structures and the random defines so that it can query UFS
> filesystems directly

at which point arguably it should have it's own UFS header.
It's not using the UFS header to use as *kernel* interface!!

--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/