Re: [patch] export ufs_fs.h to userspace

From: Alexey Dobriyan
Date: Thu Feb 08 2007 - 06:33:41 EST


On 2/8/07, Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:
On Thu, 2007-02-08 at 02:46 -0500, Mike Frysinger wrote:
> was ufs_fs.h purposefully not exported to userspace or did it just slip
> through the cracks ? assuming the latter scenario, the attached patch
> touches up the relationship between ufs_fs.h and its sub headers (like
> ufs_fs_sb.h) so that we can export it ... the silo bootloader takes
advantage
> of this header for example


are you sure it actually uses anything from this header, and not just
assumes the magic number to be there??
(also.. I kind of would think it reasonable for things with their own
UFS fs reader to have their own header)

ufs_fs.h certainly has things which certain types of userspace
programs could use:
on-disk layouts of UFS(2) inodes, cylinder groups, ... So it should be exported.

However, NAK patch in this form until all kernel internal things would
dissapear from
exported header: struct ufs_buffer_head, ufs_sb_private_info. Probably something
else, I haven't looked closely.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/