Re: [BUG][PATCH] fix mempolcy's check on a system withmemory-less-node take2

[KAMEZAWA Hiroyuki]

On Thu, 8 Feb 2007 08:49:41 +0100
Andi Kleen <ak@xxxxxxx> wrote:

> 
> > This panic(hang) was found by a numa test-set on a system with 3 nodes, where
> > node(2) was memory-less-node.
> 
> I still think it's the wrong fix -- just get rid of the memory less node.
> I expect you'll likely run into more problems with that setup anyways.
> 
memory-less-node problem is a bit big issue for this small bug.

For removing memory-less-node, we'll have to make consensus on 
"a node represents a group of memory, not cpu, not devices"

I read old e-mails on node-hotplug again.
In the early stage of node-hotplug, I assumes "a node has memory".
After discussion between several groups, I knew there are people
who consider groups of something as node.
(and we had to change our plan......)
like this (old) homepage's FAQ 5. http://lse.sourceforge.net/numa/faq/


> >  static struct mempolicy *mpol_new(int mode, nodemask_t *nodes)
> >  {
> >  	struct mempolicy *policy;
> > +	void  *val;
> 
> Using void * here is nasty when it's a zonelist pointer.
> 
okay. changes this to be more neat one..take3 will come.

-Kame




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/