[PATCH] drivers/isdn/gigaset: reduce kernel message spam

From: Tilman Schmidt
Date: Wed Feb 07 2007 - 16:41:05 EST


Reduce the number of kernel messages the Gigaset drivers produce in
case of an excessively long device response, from one per character
exceeding the limit to one per overlong message.

Signed-off-by: Tilman Schmidt <tilman@xxxxxxx>
---

isocdata.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.20-rc6-mm3-orig/drivers/isdn/gigaset/isocdata.c 2007-02-01 01:23:54.000000000 +0100
+++ linux-2.6.20-rc6-mm3-work/drivers/isdn/gigaset/isocdata.c 2007-02-05 17:35:47.000000000 +0100
@@ -921,6 +921,8 @@ static void cmd_loop(unsigned char *src,
/* end of line */
gig_dbg(DEBUG_TRANSCMD, "%s: End of Command (%d Bytes)",
__func__, cbytes);
+ if (cbytes >= MAX_RESP_SIZE - 1)
+ dev_warn(cs->dev, "response too large\n");
cs->cbytes = cbytes;
gigaset_handle_modem_response(cs);
cbytes = 0;
@@ -929,8 +931,6 @@ static void cmd_loop(unsigned char *src,
/* advance in line buffer, checking for overflow */
if (cbytes < MAX_RESP_SIZE - 1)
cbytes++;
- else
- dev_warn(cs->dev, "response too large\n");
}
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/