Re: [PATCH 1/2] Char: add __devinitdata to pci_device_ids

From: Greg KH
Date: Sat Feb 03 2007 - 10:54:24 EST


On Sat, Feb 03, 2007 at 04:39:34PM +0100, Jiri Slaby wrote:
> On 2/3/07, Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote:
> >On 2/3/07, Jiri Slaby <jirislaby@xxxxxxxxx> wrote:
> >> add __devinitdata to pci_device_ids
> >>
> >> Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
> >
> >http://lkml.org/lkml/2003/8/1/135
> >
> >I think that it is still true, Greg?

No it is not.

> Hmm, then I misunderstood this:
> http://lkml.org/lkml/2007/1/17/136
> ?

Yes, that is correct.

But Jiri, why do this? What memory savings are you seeing here now that
CONFIG_HOTPLUG is enabled by default? The only people I see liking this
kind of change are embedded, and I don't think many embedded devices
have these drivers and do not use hotplug at the same time :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/