Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

[Randy Dunlap]

Stephen Hemminger wrote:
> On Tue, 23 Jan 2007 16:33:29 -0500
> Jeff Garzik <jeff@xxxxxxxxxx> wrote:
>
> > Stephen Hemminger wrote:
> > > IMHO the MSI disabling should be removed from drivers and be done
> > > in the PCI core.
> > That is the consensus opinion.
> >
> > Currently drivers implement the MSI tests because the core PCI code 
> > hasn't been up to snuff.  I (and others) have been discouraging that, 
> > but when a user faces a choice between working and non-working network, 
> > the pragmatic solution wins.

Linus's remark (IIRC) was to not enable CONFIG_PCI_MSI then.

> > All efforts to get us to the point where we can remove the MSI tests 
> > from drivers are strongly supported...
> >
> > 	Jeff
>
> So far, either MSI works for all devices or is broken, so it makes
> sense to have a "msi=off" boot option (if there isn't already)
There is one, but it's spelled "pci=nomsi".

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/