Re: [patch 1/3] Scheduled removal of SA_xxx interrupt flags

[Thomas Gleixner]

On Tue, 2007-01-23 at 12:02 -0800, Andrew Morton wrote:
> > The name space cleanup of the interrupt request flags (SA_xxx -> IRQF_xxx)
> > left a 6 month grace period for the old deprecated flags. Remove them.
> 
> fwiw, I'll make this [patch 3/3], so the kernel compiles OK at each step.

Yup, should have thought about that.

> This is going to break a lot of external stuff.  We should have found a way
> to make usage of SA_* emit deprecated warnings (or _some_ warning) to warn
> people of impending doom.  But I can't immediately find a way of doing
> that.
> if we _can_ find a way of doing this, I suspect we'll need to do it, and
> give people another six months.  It's going to get ugly out there.  We
> shall see...

Ugly, but might work:

static inline unsigned int __deprecated __sa_shirq(void) { return IRQF_DISABLED; }
#define SA_SHIRQ	__sa_shirq()

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/