Re: Want comments regarding patch

From: Jan Engelhardt
Date: Sat Dec 30 2006 - 06:10:16 EST



On Dec 30 2006 01:00, Bodo Eggert wrote:
>Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> wrote:
>> On Dec 29 2006 07:57, Daniel MarjamÃki wrote:
>
>>> It was my goal to improve the readability. I failed.
>>>
>>> I personally prefer to use standard functions instead of writing code.
>>> In my opinion using standard functions means less code that is easier to
>>> read.
>>
>> Hm in that case, what about having something like
>>
>> void *memset_int(void *a, int x, int n) {
>> asm("mov %0, %%esi;
>> mov %1, %%eax;
>> mov %2, %%ecx;
>> repz movsd;",
>> a,x,n);
>> }
>
>This would copy the to-be-initialized buffer somewhere, if it compiles.

Yeah I don't do assembler soo often that I would know everything from heart.
All your comments are valid of course. I just wanted to point out the idea.
(However, if it's not repz, then it's repnz! :-)

-`J'
--