Re: [PATCH] Use correct macros in raid code, not raw asm

From: Linus Torvalds
Date: Thu Dec 28 2006 - 18:53:42 EST




On Fri, 29 Dec 2006, Rusty Russell wrote:
>
> This make sure it's paravirtualized correctly when CONFIG_PARAVIRT=y.

Why doesn't this code use "kernel_fpu_begin()" and "kernel_fpu_end()"?

The raid6 code is crap, and slower. It does "fsave/frstor" or movaps or
other crud, and the thing is, it shouldn't. It should just do
kernel_fpu_begin/end(), which does it all right, and avoids saving any
state at all unless it's being used by the user RIGHT NOW.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/