Re: [PATCH] introduce config option to disable DMA zone on i386

From: Arjan van de Ven
Date: Thu Dec 28 2006 - 13:37:38 EST


On Thu, 2006-12-28 at 12:34 -0600, Robert Hancock wrote:

Hi,

> > since one gets random corruption if a user gets this wrong, at least
> > make things like floppy and all CONFIG_ISA stuff conflict with this
> > option.... without that your patch feels like a walking time bomb...
> > (and please include all PCI drivers that only can do 24 bit or 28bit
> > or .. non-32bit dma as well)
>
> That sounds like a bug if this can happen. Drivers should be failing to
> initialize if they can't set the proper DMA mask, and the DMA API calls
> should be failing if the requested DMA mask can't be provided.

...but Marcelo's patch doesn't implement anything of that kind....
In addition, many ISA bus drivers do not use the DMA API *at all*
currently. If you want to fix them all up, great! But somehow I doubt
those will get fixed in the next decade.. they've been like this for at
least half a decade or longer :-)

Greetings,
Arjan van de Ven


--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/