Re: [PATCH 2.6.20-rc1 00/10] Kernel memory leak detector 0.13

From: Catalin Marinas
Date: Wed Dec 27 2006 - 11:30:47 EST


On 27/12/06, Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:
On Wed, 2006-12-27 at 16:14 +0000, Catalin Marinas wrote:
> On 17/12/06, Ingo Molnar <mingo@xxxxxxx> wrote:
> > it would be nice to record 1) the jiffies value at the time of
> > allocation, 2) the PID and the comm of the task that did the allocation.
> > The jiffies timestamp would be useful to see the age of the allocation,
> > and the PID/comm is useful for context.
>
> Trying to copy the comm with get_task_comm, I get the lockdep report
> below, caused by acquiring the task's alloc_lock. Any idea how to go
> around this?

well you take the lock from irq context, which means it needs to use
_irqsave/restore everywhere. (and all locks taken inside it must be irq
safe as well)

maybe.. not use comm in irq context? it doesn't actually mean anything
there anyway...

Thanks. Done this and it is ok now.

--
Catalin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/