Re: [patch 2.6.20-rc1 6/6] S3C2410 GPIO wrappers

[Russell King]

On Thu, Dec 21, 2006 at 11:33:11AM +0100, Arnaud Patard wrote:
> > +#include <asm/arch/irqs.h>
> 
> imho, this is not needed. The user who will use irq will add it in his
> code anyway.
> 
> > +#include <asm/arch/hardware.h>

This is a pet peave.  _NO_ drivers should include either of these two
headers directly.  Use asm/irq.h and asm/hardware.h instead.  Audit your
code to ensure that you're including the right headers please.

I can see that I've got to do another sweep of the entire kernel code
to fix all these again.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/