Re: [patch] mm: export cancel_dirty_page()

From: Linus Torvalds
Date: Thu Dec 21 2006 - 19:56:30 EST




On Fri, 22 Dec 2006, Ingo Molnar wrote:
>
> ah, indeed - but i dont see a fundamental reason why hugetlbfs is not
> modular. Nevertheless exporting this makes sense. My quick hack below to
> guess to convert reiserfs (just to make the rpm build) also needs it.

Yes, it should be exported regardless.

Hoiwever, I'm not sure your reiserfs change is valid: why was that old
code testing "PAGE_SIZE == bh->b_size"?

(Not that I see why the _old_ code would be valid either, and why you'd
ever care about b_size being PAGE_SIZE, but I'm just wondering..)

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/