Re: Changes to sysfs PM layer break userspace

From: Andrew Morton
Date: Tue Dec 19 2006 - 22:50:33 EST


On Tue, 19 Dec 2006 18:35:39 -0800
Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:

> On Tue, 19 Dec 2006 18:15:24 -0800 Andrew Morton wrote:
>
> > On Tue, 19 Dec 2006 13:34:49 -0800
> > David Brownell <david-b@xxxxxxxxxxx> wrote:
> >
> > > Documentation/feature-removal-schedule.txt has warned about this since
> > > August
> >
> > Nobody reads that.
>
> Ugh, I read it.
>
> > Please, wherever possible, put a nice printk("this is going away") in the code
> > when planning these things.
>
> Can notices go in both places, or is in the source code (printk)
> now the preferred way?

I think printks grab a lot more attention. It's not surprising that people
get surprised when the feature they're using goes away.

Plus they may not even know that that they're using the feature. A printk
fixes that.

> I think that we can point people to Doc/feature-removal-schedule.txt
> easier (and more effectively) than we can source code (or noisy kernel
> logs).

Hopefully developers who see the printk will think to look in
feature-removal-schedule.txt for more details.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/