Re: [PATCH 2/5] Char: isicom, fix probe race

[Andrew Morton]

On Sat, 16 Dec 2006 02:09:48 +0100 (CET)
Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> isicom, fix probe race
> 
> Fix two race conditions in the probe function with mutex.
> 
> ...
>
>  static int __devinit isicom_probe(struct pci_dev *pdev,
>  	const struct pci_device_id *ent)
>  {
> +	static DEFINE_MUTEX(probe_lock);

hm.  How can isicom_probe() race with itself?  Even with the dreaded
multithreaded-pci-probing?  It's only called once, by a single thread.

Confused.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/